I've got a Ledger Nano S, and it works fine. It's a bit of a faff if you've multiple currencies, as it only has a small amount of space so you have to uninstall the app for one coin to make room for another, but if you're only doing Bitcoin, Eth, and one or two others you'll be grand. Never used a Trezor, but I've heard good things there too. I've also played with the Coinkite ColdCard and OpenDime. They're both rubbish, and the guy who runs the company is a right knobber. Avoid. On the mining front, I stopped after my first payout. It worked well enough, but I didn't like leaving my desktop on all the time *and* it dragged the performance down in certain apps. LibreOffice Writer was particularly impacted.