Development structs in c

can anyone help with the code below:

Code:

#include <stdio.h>
#include <string.h>
int main()
{
	struct Person
	{
		char name[30] ;
		int  age      ;
		int  regNo    ;
		int  wage     ;
	} ;	

	struct Person emp1 ;
	struct Person emp2 ;

	scanf("%s%i%i%i", emp1.name,  emp1.age, emp1.regNo, emp1.wage) ;
	strcpy(emp2.name, emp1.name) ;
	emp2.regNo = 666 ;
	emp2.wage = emp1.wage * 2 ;
	printf("%s %i %i %i\n", emp1.name,  emp1.age, emp1.regNo, emp1.wage) ; 
	printf("%s %i %i %i\n", emp2.name,  emp2.age, emp2.regNo, emp2.wage) ;
	
	return 0 ;
}

This is returning a segmentation fault when I try it on a redhat server and a bus error on my mac, can anyone tell me why, I am trying to learn C programming and it's got me a bit stuck

Thanks

 

Scanf expects pointers

Post back if that doesn't help you -- are we doing your homework?

Spoiler

hint: &

 

Thanks RTT, I have actually just realised I did and metaphorically kicked myself for it. Rather a stupid mistake.

Some module work for uni that I just couldn't work out, I thought I wouldn't be able to and didn't want to wait until Monday to ask a lecturer.

Thanks for your help.

 

Easily done I'd tidy it up as follows

Code:

#include <stdio.h>
#include <string.h>
int main()
{
	struct Person
	{
		char name[30];
		int  age, regNo, wage;
	} emp1, emp2;	

	scanf("%s %i %i %i", &emp1.name, &emp1.age, &emp1.regNo, &emp1.wage);

	strcpy(emp2.name, emp1.name);
	emp2.regNo = 666;
	emp2.wage = emp1.wage * 2;

	printf("%s %i %i %i\n%s %i %i %i\n", emp1.name, emp1.age, emp1.regNo, emp1.wage, emp2.name, emp2.age, emp2.regNo, emp2.wage); 

	return 0;
}

You could also improve it by making an array of Persons and loop over them to do the output stage rather than having two identical printf()s or one big long one.

 

Shouldn't emp1.name already be a pointer since an index is not specified into the array. Is scanf expecting a double pointer, or am I just missing something?